[PSCmdAssistant] New-AzVM and Vmss default image to Win2022AzureEdition when user explicitly sets SecurityType to Standard #24773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
|
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 62.50 % | 66.67% | Test coverage cannot be lower than the number of the last release. |
⚠️ - MacOS
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 62.50% | 66.67% | Test coverage cannot be lower than the number of the last release. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 62.50% | 66.67% | Test coverage cannot be lower than the number of the last release. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 62.50% | 66.67% | Test coverage cannot be lower than the number of the last release. |
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
|
@Sandido , please check new added code, many test cases failed due to |
Sandido
changed the title
Sandido
commented
May 9, 2024
src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1
Outdated
Show resolved
Hide resolved
...mpute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetCreateOrUpdateMethod.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs
Show resolved
Hide resolved
src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs
Show resolved
Hide resolved
src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs
Show resolved
Hide resolved
| @@ -781,9 +780,15 @@ async Task StrategyExecuteCmdletAsync(IAsyncCmdlet asyncCmdlet) | |||
| this.EnableVtpm = this.EnableVtpm ?? true; | |||
| this.EnableSecureBoot = this.EnableSecureBoot ?? true; | |||
| } | |||
| // Default in TL Image to ease later migration. | |||
There was a problem hiding this comment.
i see this is the only part updated for New-AzVM,
does this code path apply to both Simple and Default parameter set ?
There was a problem hiding this comment.
The ask is for only this parameter set, I have not tested the other.
|
@YanaXu , please consider this for this breaking change release. |
|
To the author of the pull request, |
YanaXu
reviewed
May 13, 2024
|
|
||
| ## Version 7.3.0 | ||
| * Added cmdlet `Invoke-AzSpotPlacementRecommender`. | ||
| * Fixed `Update-AzCapacityReservationGroup` to remove Subscriptions from SharingProfile. | ||
| * Added new optional parameter `SecureVMGuestStateSAS` to cmdlet `Grant-AzDiskAccess`. |
There was a problem hiding this comment.
Why to add this line in "version 7.3.0". Please refer to https://www.powershellgallery.com/packages/Az.Compute/7.3.0. Usually we do not update the former versions. It doesn't work.
There was a problem hiding this comment.
Hi @Sandido , I've merged this PR to save time. Please double confirm why to add this line in a former release. If there is a reason, please comment in this PR and let's see what's the right thing to do.
YanaXu
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
design request: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1408
When the SecurityType is explicitly set to Standard, now defaulting the image to Win2022AzureEdition to let users migrate to TrustedLaunch securityType more easily in the future.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.