keep port when exists (#4018)

* use negative target port as the way to know the target port should not be changed * update generation instead of the quick hack * test
Azure · Jun 18, 2024 · 4da74ab · 4da74ab
1 parent 8eddbc5
commit 4da74ab
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 7 deletions.
diff --git a/cli/azd/pkg/apphost/aca_ingress.go b/cli/azd/pkg/apphost/aca_ingress.go
@@ -251,6 +251,7 @@ func pickIngress(endpointByTargetPortProperties map[string]*acaPort, httpIngress
  finalIngress.TargetPort = props.port
  if finalIngress.TargetPort == 0 {
  finalIngress.TargetPort = defaultPort
+ finalIngress.UsingDefaultPort = true
  }
  finalIngress.Transport = acaIngressSchemaHttp
  if props.hasHttp2 {

diff --git a/cli/azd/pkg/apphost/aca_ingress_test.go b/cli/azd/pkg/apphost/aca_ingress_test.go
@@ -41,6 +41,7 @@ func TestBuildAcaIngress(t *testing.T) {
  Transport: acaIngressTransportHttp2,
  AllowInsecure: true,
  AdditionalPortMappings: []genContainerAppIngressAdditionalPortMappings(nil),
+ UsingDefaultPort: true,
  }
  ingress, ingressBinding, err := buildAcaIngress(bindings, 8080)
  assert.NoError(t, err)
@@ -176,6 +177,7 @@ func TestBuildAcaIngress(t *testing.T) {
  },
  },
  },
+ UsingDefaultPort: true,
  }
  ingress, ingressBinding, err := buildAcaIngress(bindings, 8080)
  assert.NoError(t, err)

diff --git a/cli/azd/pkg/apphost/generate.go b/cli/azd/pkg/apphost/generate.go
@@ -178,7 +178,19 @@ func ContainerAppManifestTemplateForProject(
 
  var buf bytes.Buffer
 
- tmplCtx := generator.containerAppTemplateContexts[projectName]
+ type yamlTemplateCtx struct {
+ genContainerAppManifestTemplateContext
+ TargetPortExpression string
+ }
+ tCtx := generator.containerAppTemplateContexts[projectName]
+ tmplCtx := yamlTemplateCtx{
+ genContainerAppManifestTemplateContext: tCtx,
+ TargetPortExpression: fmt.Sprintf("{{ targetPortOrDefault %d }}", tCtx.Ingress.TargetPort),
+ }
+ if tCtx.Ingress.TargetPort != 0 && !tCtx.Ingress.UsingDefaultPort {
+ // not using default port makes this to be a non-changing value
+ tmplCtx.TargetPortExpression = fmt.Sprintf("%d", tCtx.Ingress.TargetPort)
+ }
 
  err := genTemplates.ExecuteTemplate(&buf, "containerApp.tmpl.yaml", tmplCtx)
  if err != nil {

diff --git a/cli/azd/pkg/apphost/generate_types.go b/cli/azd/pkg/apphost/generate_types.go
@@ -49,6 +49,7 @@ type genContainerAppIngress struct {
  genContainerAppIngressPort
  Transport string
  AllowInsecure bool
+ UsingDefaultPort bool
  AdditionalPortMappings []genContainerAppIngressAdditionalPortMappings
 }
 

diff --git a/cli/azd/pkg/apphost/testdata/TestAspireContainerGeneration-kafka.snap b/cli/azd/pkg/apphost/testdata/TestAspireContainerGeneration-kafka.snap
@@ -14,7 +14,7 @@ properties:
  autoConfigureDataProtection: true
  ingress:
  external: false
- targetPort: {{ targetPortOrDefault 9092 }}
+ targetPort: 9092
  exposedPort: 6000
  transport: tcp
  allowInsecure: false

diff --git a/cli/azd/pkg/apphost/testdata/TestAspireContainerGeneration-my-sql-abstract.snap b/cli/azd/pkg/apphost/testdata/TestAspireContainerGeneration-my-sql-abstract.snap
@@ -14,7 +14,7 @@ properties:
  autoConfigureDataProtection: true
  ingress:
  external: false
- targetPort: {{ targetPortOrDefault 3306 }}
+ targetPort: 3306
  transport: tcp
  allowInsecure: false
  registries:

diff --git a/cli/azd/pkg/apphost/testdata/TestAspireContainerGeneration-noVolume.snap b/cli/azd/pkg/apphost/testdata/TestAspireContainerGeneration-noVolume.snap
@@ -14,7 +14,7 @@ properties:
  autoConfigureDataProtection: true
  ingress:
  external: false
- targetPort: {{ targetPortOrDefault 3306 }}
+ targetPort: 3306
  transport: tcp
  allowInsecure: false
  registries:

diff --git a/cli/azd/pkg/apphost/testdata/TestAspireDockerGeneration-nodeapp.snap b/cli/azd/pkg/apphost/testdata/TestAspireDockerGeneration-nodeapp.snap
@@ -14,7 +14,7 @@ properties:
  autoConfigureDataProtection: true
  ingress:
  external: true
- targetPort: {{ targetPortOrDefault 3000 }}
+ targetPort: 3000
  transport: http
  allowInsecure: false
  registries:

diff --git a/cli/azd/resources/apphost/templates/containerApp.tmpl.yamlt b/cli/azd/resources/apphost/templates/containerApp.tmpl.yamlt
@@ -46,7 +46,7 @@ properties:
 {{- end}}
 {{- end}}
  external: {{ .Ingress.External }}
- targetPort: {{ "{{ targetPortOrDefault " }}{{ .Ingress.TargetPort }}{{ " }}" }}
+ targetPort: {{ .TargetPortExpression }}
 {{- if gt .Ingress.ExposedPort 0 }}
  exposedPort: {{ .Ingress.ExposedPort }}
 {{- end}}

diff --git a/.../test/functional/testdata/snaps/aspire-full/AspireAzdTests.AppHost/infra/pubsub.tmpl.yaml b/.../test/functional/testdata/snaps/aspire-full/AspireAzdTests.AppHost/infra/pubsub.tmpl.yaml
@@ -14,7 +14,7 @@ properties:
  autoConfigureDataProtection: true
  ingress:
  external: false
- targetPort: {{ targetPortOrDefault 6379 }}
+ targetPort: 6379
  transport: tcp
  allowInsecure: false
  registries: