-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM64 build compatibility #36
base: master
Are you sure you want to change the base?
Conversation
I am also interested in the arm64 release of acr-docker-credential-helper. I was trying to build with these changes in arm64. I think there are few changes required to make it work on arm64. Please check below for the changes required:
After these changes, the binary for arm64 was created successfully. So, I think it will be good to add the small changes mentioned above to make it in arm64. |
Actually I launch the build by providing GOARCH as a parameter, and it works without any issue. But yes your modification would make it nicer. I'll test and update |
I've modified all the scripts to allow the build for arm64