Swap out legacycrypt for crypt-r for Python 3.13+ #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Azure#3070 pulled in legacycrypt to replace the removed crypt module. legacycrypt hasn't been updated since it was initially pulled out of Python's stdlib in 2019 (Python 3.7). crypt-r pulls in the module as it was in Python 3.12. While there's been no major developments since 3.7, it's more likely to be kept updated for any breakages in future Python releases. It's also already packaged for Fedora and means one less package for me to maintain so that would be nice.
jeremycline
requested review from
narrieta,
ZhidongPeng,
nagworld9 and
maddieford
as code owners
|
@jeremycline Thanks for the change. We implemented temporary workaround to use legacycrypt to fix importing crypt issue on agent start. But the code that's need crypt() function from crypt module is owned by(JIT) team. We started a discussion with them and will let JIT team to handle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #3070 pulled in legacycrypt to replace the removed crypt module. legacycrypt hasn't been updated since it was initially pulled out of Python's stdlib in 2019 (Python 3.7). crypt-r pulls in the module as it was in Python 3.12. While there's been no major developments since 3.7, it's more likely to be kept updated for any breakages in future Python releases.
It's also already packaged for Fedora and means one less package for me to maintain so that would be nice.
PR information
Quality of Code and Contribution Guidelines