Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] FEAT Add adversarial suffix attack GCG #180

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

NaijingGuo
Copy link
Contributor

Description

suffix attack from https://arxiv.org/pdf/2307.15043.pdf
TODO:

  • support llama3 and Phi-3
  • test and add in the script for multiple prompt multiple models
  • add the option to specify what token is not allowed as suffix
  • [add suffix examples suffix converter] (need approval)

Tests and Documentation

Tests and documentation to be added.

@NaijingGuo please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@romanlutz romanlutz linked an issue Apr 29, 2024 that may be closed by this pull request
pyrit/adv_suffix/data/advbench/harmful_behaviors.csv Outdated Show resolved Hide resolved
worker.stop()


if __name__ == "__main__":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a "main" script, let's have a class, e.g., GreedyCoordinateGradientAdversarialSuffixGenerator (wow that's long...) that takes the parameters as inputs and has a method generate_suffix. We can call it from a notebook (I would put it under doc/demo/7_adversarial_suffix (the number may change but that's fine).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the code to put things in a class as suggested, generate_suffix under the class can be called from outside. The change can be seen in 2 files, named test_main.py (contains the class) and test_demo.py (contains example usage of the class).

However, because the original code uses multiprocessing, if __name__ == "__main__" guard is required to run the code, and this would also introduces difficulty running in Jupyter notebook (although I have been using python scripts only, since the school cluster does not support notebook). My main reference is here:

In other words, in my test_demo.py, I cannot remove if __name__ == "__main__ and run generate_suffix directly. I have not found a way to circumvent this yet (but I'm completely new to multiprocessing, there might be ways that I have not dug up yet somewhere in Stack Overflow...)

I was wondering if if __name__ == "__main__" guard is a huge problem and we should stop using multiprocessing altogether, or we can keep the demo like test_demo.py for now, or there are some ways that you know that can help circumvent this problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about notebooks. I expect this code will always be executed on a compute node of some kind using a little script that has the main guard BUT the logic should be only in the code files if that makes sense. For example, we have all our logic in the pyrit package today and can call it in a notebook. But we could just as well use a little python script to call it without a notebook. The notebook is just one way.

Do you have a recommendation on how to run it? I can try if it works

Copy link
Contributor Author

@NaijingGuo NaijingGuo May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the test_demo.py file would be the little script to run suffix generation (I can run it without any problem, but please let me know if it doesn't work for you). The main logic is in the test_main.py, and test_demo.py only specifies model name and training parameters, like training steps, batch size, etc..

(The two files were called test_xxx because they are my draft to refactor the original main and the bash script to run main. I have not deleted the original code yet.)

# data = json.load(open('eval/individual_behavior_controls.json', 'r'))


if __name__ == "__main__":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to put everything in classes & functions, and call them from notebooks under doc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have refactored the parse_scirpt.py and the evaluation into a class called AdversarialSuffixEvaluator (this class in the new test_evaluation.py. And an example to run the evaluation can be found in the new test_eval_demo.py.

If the evaluator and generator class both looks good, I will combine the demo code files such that it can run both generation and evaluation.

del control_cands, loss
gc.collect()

print("Current length:", len(self.workers[0].tokenizer(next_control).input_ids[1:]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not urgent, but eventually we'd want to use the logger the same way we do elsewhere in the repo. That way, you can specify the desired log level and only see the corresponding output.

pyrit/adv_suffix/experiments/evaluate_individual.py Outdated Show resolved Hide resolved
@romanlutz romanlutz requested a review from dlmgary April 29, 2024 20:03
@NaijingGuo NaijingGuo marked this pull request as draft May 5, 2024 21:17
@romanlutz
Copy link
Contributor

FYI #192 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT Add adversarial suffix attack GCG
3 participants