Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [feat/doc-updates] open external links in new tab/window #1652

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

ReneHezser
Copy link
Contributor

@ReneHezser ReneHezser commented Oct 30, 2024

Overview/Summary

This is a PR not for the main branch

External links will be opened in a new tab instead of navigating away from the current page.

This PR fixes/adds/changes/removes

none

Breaking Changes

none

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@ReneHezser ReneHezser requested a review from a team as a code owner October 30, 2024 15:39
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 30, 2024
@ReneHezser
Copy link
Contributor Author

@matebarabas the first PR for the doc update branch

@ReneHezser ReneHezser changed the title feat: open external links in new tab/window doc-update feat: open external links in new tab/window Oct 30, 2024
@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Oct 30, 2024

Hey @ReneHezser,
would that then be the case for literally all links? I'd usually use my mousewheel if I want to open somthing in a new tab and otherwise would always want to navigate to a given page. Not saying we cannot change it - but if this works like I think it will, then we're essentially limiting the user 😄

Asking for a friend

@ReneHezser
Copy link
Contributor Author

ReneHezser commented Oct 31, 2024

Asking for a friend

Hey @AlexanderSehr and Alex's friend
I understand the concerns your friend has. The web is divided if it is best to open external links (pointing to another domain) should be opened in a new tab/window, or not. In our case, I would like to do so, as they provide additional information to read, but would navigate away from the "follow me guide" on the site.

@matebarabas
Copy link
Contributor

matebarabas commented Oct 31, 2024

A few comments/thoughts:

  • I think opening external links in a new tab is common best practice, so I think we should adapt this practice - which as per the intent does just that, even if it looks like it would result in false positives. :)
  • We need to test/make sure that this solution really only gets triggered in case of external links (i.e., stuff outside of the AVM website, including any of the GH repos, etc.)
  • We need to test/make sure that this gets triggered in case of http and https links.
  • This PR is not for main, but for a long-standing documentation branch, we'll collaborate on and release to main when we're ready for the first wave of changes.

@ReneHezser ReneHezser changed the title doc-update feat: open external links in new tab/window feat: [feat/doc-update] open external links in new tab/window Nov 6, 2024
@ReneHezser ReneHezser changed the title feat: [feat/doc-update] open external links in new tab/window feat: [feat/doc-updates] open external links in new tab/window Nov 6, 2024
@ReneHezser ReneHezser requested review from matebarabas and jchancellor-ms and removed request for a team November 6, 2024 16:14
@ReneHezser ReneHezser self-assigned this Nov 6, 2024
@ReneHezser ReneHezser merged commit fae8c51 into Azure:feat/doc-updates Nov 6, 2024
3 of 4 checks passed
@ReneHezser ReneHezser deleted the external-links branch November 6, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants