-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI split data in different tables #11499
base: master
Are you sure you want to change the base?
Conversation
Solutions/Oracle Cloud Infrastructure/Data Connectors/AzureFunctionOCILogs/main.py
Fixed
Show fixed
Hide fixed
Solutions/Oracle Cloud Infrastructure/Data Connectors/AzureFunctionOCILogs/main.py
Fixed
Show fixed
Hide fixed
Solutions/Oracle Cloud Infrastructure/Data Connectors/AzureFunctionOCILogs/main.py
Fixed
Show fixed
Hide fixed
# return "OCI_LoadBalancerLogs" | ||
if event["type"] == "com.oraclecloud.Audit.ListEvents": | ||
return "OCI_AuditLogs" | ||
if event["type"] == "com.oraclecloud.vcn.flowlogs.DataEvent" or event["type"] == "com.oraclecloud.vcn.flowlogs.QualityEvent.NoData" or event["type"] == "com.oraclecloud.virtualNetwork.GetVcn" or event["type"] == "com.oraclecloud.virtualNetwork.ListVcns" or event["type"] == "com.oraclecloud.vcn.flowlogs.QualityEvent.SkipData" or event["type"] == "com.oraclecloud.virtualNetwork.GetVcnDnsResolverAssociation": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would change this to use contains so we won't miss any data types
@@ -65,7 +65,15 @@ def determine_log_type(event): | |||
# return "OCI_LoadBalancerLogs" | |||
if event["type"] == "com.oraclecloud.Audit.ListEvents": | |||
return "OCI_AuditLogs" | |||
if event["type"] == "com.oraclecloud.vcn.flowlogs.DataEvent" or event["type"] == "com.oraclecloud.vcn.flowlogs.QualityEvent.NoData" or event["type"] == "com.oraclecloud.virtualNetwork.GetVcn" or event["type"] == "com.oraclecloud.virtualNetwork.ListVcns" or event["type"] == "com.oraclecloud.vcn.flowlogs.QualityEvent.SkipData" or event["type"] == "com.oraclecloud.virtualNetwork.GetVcnDnsResolverAssociation": | |||
if event["type"] == "com.oraclecloud.computeApi.ListVolumeAttachments" or event["type"] == "com.oraclecloud.computeApi.ListVnicAttachments" or event["type"] == "com.oraclecloud.computeApi.ListBootVolumeAttachments" or event["type"] == "com.oraclecloud.computeApi.GetInstance": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As i said before we should do a contains in order to classifiy each log type instead of parssing each type,
reason:
in the future there is an option that it may be a new event data type for example :
com.oraclecloud.vcn.newqtype
because we are using == instead of in this log will be sent to the defualt talbe and not to the relevant one
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.