Add json schema for built-in feature filters #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
mrm9084,
Eskibear,
zhenlan,
rossgrambo,
jimmyca15,
amerjusupovic and
ivywei0125
mrm9084
reviewed
Apr 24, 2024
ivywei0125
reviewed
Apr 29, 2024
zhenlan
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Should we name the file name Microsoft.Targeting.*?
There was a problem hiding this comment.
I am ok with naming the file with "Microsoft.xxx". We don't have Microsoft prefix for feature flag and feature management schema. Should we change them all?
There was a problem hiding this comment.
We don't have Microsoft prefixed to feature flag or feature management anywhere. It's just branding. For filters, Microsoft.Targeting is the actual complete name users put in their feature flags and we expect from the code.
If we do change the name, it will be unclear this is about filters, so we probably can put them in a subfolder, eg., FeatureManagement/FeatureFilters.
Eskibear
reviewed
May 14, 2024
docs/FeatureManagement/FeatureFilters/Microsoft.TimeWindow.v2.0.0.schema.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.