-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RP E2E Test Execution #3856
Draft
shubhadapaithankar
wants to merge
51
commits into
master
Choose a base branch
from
shubhadapaithankar/ARO-9501-RP-E2E-Test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
RP E2E Test Execution #3856
shubhadapaithankar
wants to merge
51
commits into
master
from
shubhadapaithankar/ARO-9501-RP-E2E-Test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhadapaithankar
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam and
bitoku
as code owners
September 20, 2024 22:43
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-9501-RP-E2E-Test
branch
7 times, most recently
from
September 23, 2024 18:39
ed42f14
to
f62f93f
Compare
- Added az acr login before docker compose up.
- Removed --target=builder for RP and E2E image builds so all stages are built.
- Added ARO_IMAGE env var to set ARO operator image URL.
- Added version to the ARO_IMAGE env var and set to Build.BuildId.
- Moved Build.BuildId variable inside quotes.
kevinobriendotca
force-pushed
the
shubhadapaithankar/ARO-9501-RP-E2E-Test
branch
from
November 1, 2024 22:48
3d795ef
to
deeca9a
Compare
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-9501-RP-E2E-Test
branch
from
November 5, 2024 15:58
153769a
to
e6ba412
Compare
- Added WORKDIR setting and set to /usr/local/bin to fix portalauth command invocation.
- Updated ARO_IMAGE env var to use new arosvcdev registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: ARO-9501
What this PR does / why we need it:
This PR introduces an E2E testing stage using Docker Compose to orchestrate the RP, Selenium, and E2E test services. The pipeline pulls the required RP image from Azure Container Registry (ACR) and ensures the correct environment is set up for the E2E tests. It helps validate the end-to-end functionality of the system and ensures that tests are running using containerized RP images.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
N/A