Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin all the requirements #141

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Pin all the requirements #141

merged 5 commits into from
Dec 2, 2024

Conversation

pamelafox
Copy link
Contributor

Purpose

Fixes #140

We keep running into issues with package dependencies, so the safest thing to do is to pin them all (as long as all still work on Windows).
There was also an issue with installing the evaluation requirements, so I moved that out of requirements-dev.txt for now.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Type of change

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff manually on my code.

@pamelafox pamelafox merged commit 61bde71 into main Dec 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible pip packages opentelemetry-semantic-conventions 0.49b
1 participant