Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: even more warnings removed #9857

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Nov 8, 2024

Similar to #9819, except I'm now also replacing some usage of storage[] for get and set, and I added some constraining comments.

@nventuro nventuro requested review from sklppy88 and benesjan and removed request for fcarreiro and dbanks12 November 8, 2024 19:55
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nventuro nventuro enabled auto-merge (squash) November 11, 2024 14:52
@nventuro nventuro merged commit f961c26 into master Nov 11, 2024
65 checks passed
@nventuro nventuro deleted the nv/its-warnings-again-isnt-it branch November 11, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants