-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure VirtualizingStackPanel correct element size estimate and fix #17460 #17461
base: master
Are you sure you want to change the base?
Conversation
This is one possible solution that fixes the problem. I'll let the Avalonia experts correct me if there's a better way |
You can test this PR using the following package version. |
@grokys is there anything I can do here to help the review? |
You can test this PR using the following package version. |
Closing as issue cannot be properly reproduced |
I think we need an API for different ItemSize estimations. |
@timunie I'm going to create a repos to reproduce the issue and further investigate. My approach here did fix the problem though. Happy for you to give more details about your idea too |
It's available in Avalonia.Labs but not ready for public release yet. Still has a performance overhead for sure, so not suited everywhere. AvaloniaUI/Avalonia.Labs#92 > |
Reopened the PR |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
What does the pull request do?
Ensure
VirtualizingStackPanel
's_lastEstimatedElementSizeU
is set before callingCalculateDesiredSize()
.As a result, the vertical scroll bar will be correctly sized.
What is the current behavior?
The Vertical scroll bar size is not correct until the view is scroll down to its maximum.
What is the updated/expected behavior with this PR?
Checklist
Breaking changes
n/a
Obsoletions / Deprecations
n/a
Fixed issues
Fixes #17460