Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#2263 - Convert templates from markdown to tgb #2367

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feature/#2263 - Convert templates from markdown to tgb #2367

wants to merge 2 commits into from

Conversation

trgiangdo
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This PR updates the usage of Markdown in the templates to the Gui builder API.

Related Tickets & Documents

Checklist

We encourage you to keep the code coverage percentage at 80% and above.

  • This solution meets the acceptance criteria of the related issue.
  • The related issue checklist is completed.
  • This PR adds unit tests for the developed code. If not, why?
  • End-to-End tests have been added or updated. If not, why?
  • The documentation has been updated, or a dedicated issue created. (If applicable)
  • The release notes have been updated? (If applicable)

@trgiangdo trgiangdo added the 📈 Improvement Improvement of a feature. label Dec 24, 2024
@trgiangdo trgiangdo self-assigned this Dec 24, 2024
@AlexandreSajus
Copy link
Contributor

How should I test this? If I pip install taipy develop and try creating templates with taipy create, would that allow me to test this feature?

@jrobinAV
Copy link
Member

How should I test this? If I pip install taipy develop and try creating templates with taipy create, would that allow me to test this feature?

It s not yet merged into develop. You can test it by installing the version of branch feature/#2263-convert-templates-from-markdown-to-tgb directly.

jrobinAV
jrobinAV previously approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the center tag around the navbar (I don't know how that works with tgb), the rest looks good.

taipy/templates/default/hooks/post_gen_project.py Show resolved Hide resolved
taipy/templates/default/{{cookiecutter.__root_folder}}/pages/page_example/page_example.py Show resolved Hide resolved
AlexandreSajus
AlexandreSajus previously approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@AlexandreSajus AlexandreSajus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine 👍

@trgiangdo trgiangdo dismissed stale reviews from AlexandreSajus and jrobinAV via 6b65e01 December 25, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanferM JuanferM JuanferM left review comments

@FlorianJacta FlorianJacta Awaiting requested review from FlorianJacta

@jrobinAV jrobinAV Awaiting requested review from jrobinAV

@AlexandreSajus AlexandreSajus Awaiting requested review from AlexandreSajus

At least 1 approving review is required to merge this pull request.

Assignees

@trgiangdo trgiangdo

Labels
📈 Improvement Improvement of a feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert templates from Markdown to TGB
4 participants
@trgiangdo @AlexandreSajus @jrobinAV @JuanferM