Fix - setting width/height with CSS units for metrics #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test for default metric behavior - Document bug where numeric width/height values default to 100% - Document bug where px unit width/height values are ignored - Tests verify current behavior for future fix verification
I added several unit tests for the NormalizeSize function to ensure that our code meets coverage requirements and to validate the correctness of the function
FlorianJacta
requested review from
namnguyen20999,
FabienLelaquais and
FredLL-Avaiga
and removed request for
namnguyen20999 and
FabienLelaquais
FredLL-Avaiga
requested changes
Dec 10, 2024
|
This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines. |
github-actions
bot
added
the
🥶Waiting for contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The Metric component was not responding to size style values with units such as
width='100px'orheight='100%'because it uses an externalPlotlibrary that only accepts numerical sizes. This change adds a function that converts any size dimensions into a number of pixels, which can then be interpreted by thePlotproperly.Related Tickets & Documents
How to reproduce the issue
The file doc/gui/examples/controls/css_bug.py has example components and styles that previously did not respond to variable width/height Metric components. Running this file now should show the Metric component properly working.
Checklist
We encourage you to keep the code coverage percentage at 80% and above.