Added Feature Cover Json Data Node in Data Node control #2164
Conversation
|
@quest-bot loot #1248 |
|
| @@ -756,6 +757,29 @@ const DataNodeViewer = (props: DataNodeViewerProps) => { | |||
| ) : null} | |||
| </Stack> | |||
| </Box> | |||
| <div> | |||
| { dtType === "json" ? ( | |||
There was a problem hiding this comment.
Did you check that this type is set by the backend ?
There was a problem hiding this comment.
No i didn't checked as on the issue the user was using json data so i thought i will make it in a condition so that only json data will be collapsed.
There was a problem hiding this comment.
Here is what is a taipy.core.data_node
A data_node can contain any type of data (scalar, tabular, structured, db view ...)
the data_node component tries to display a data_node and its underlying data.
There was a problem hiding this comment.
as per
taipy/taipy/gui_core/_adapters.py
Line 205 in 63f0cbf
the best we can hope for is a dict value for dtType and that's what we get if the DataNode used is a JSONDataNode.
Described here
Line 141 in 9373005
There was a problem hiding this comment.
Thanks for sharing this i was having a really hard time with the backend.
THEBOSS0369
force-pushed
the
feature/#1248-cover-json-data-node-control-new
branch
from
12fb4e6
to
7daba5e
Compare
Hey @FredLL-Avaiga ! Apologies for late reply. I have created a test file can you tell me in which folder should i add that file , this is the test file in the root folder
|
What does this show ? that you can display some json data in a markdown page ? |
|
please fix the failing checks |
Yes sir i will fix these errors. |
THEBOSS0369
force-pushed
the
feature/#1248-cover-json-data-node-control-new
branch
from
58feaaa
to
00272c1
Compare
|
@FredLL-Avaiga The test is failing because of the it can resolve if i import it from |
Sir, I will be adding this in the next commit |
You have to update your dependencies |
Got it Sir , This will work! Also I won't be able to share any update till tomorrow due to Diwali Festival. Hope you understand 😀 |
Enjoy the festival 🙏 |
There was a problem hiding this comment.
to make things work, you will nee to modify the backend also:
in _adapters.py
taipy/taipy/gui_core/_adapters.py
Line 190 in 63f0cbf
the static method should be
@staticmethod
def _is_tabular_data(datanode: DataNode, value: t.Any):
return isinstance(datanode, _TabularDataNodeMixin) or (
isinstance(value, (pd.DataFrame, pd.Series, list, tuple, dict)) and not isinstance(datanode, JSONDataNode)
)PS do not forget to import JSONDataNode
from taipy.core.data import JSONDataNode
|
|
||
| # Define the page with the JSON viewer | ||
| page = """ | ||
| <|{json_data}|json|expandable|> |
There was a problem hiding this comment.
did you try to run this ?
This should be something like
import taipy as tp
import taipy.gui.builder as tgb
from taipy import Config, Orchestrator, Scope
from taipy.gui import Gui
json_config_node = Config.configure_json_data_node(
id="json_node",
default_path="./demo-1248-dn.json",
scope=Scope.GLOBAL,
)
with tgb.Page() as data_node_viewer:
tgb.html("h2", "Discovering Data Node json viewer")
tgb.data_node(
data_node="{json_data_node}"
)
gui = Gui(page=data_node_viewer)
if __name__ == "__main__":
Orchestrator().run()
json_data_node = tp.create_global_data_node(json_config_node)
gui.run(title="1248 json data_node")
| <> | ||
| <Suspense fallback={<div>Loading JSON...</div>}> | ||
| <Grid container spacing={2}> | ||
| <Grid xs={12}> |
There was a problem hiding this comment.
change xs={12} to size={12}
This PR fixes #1248
Hey Everyone!
In this PR, The changes has been done in
DataNodeViewer.tsxfile, Now Data in Json can be collapsed or expand as the user wish.I have imported
react-json-viewbecause it will make our process much easier.Thanks!