-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Job Viewer visual element to display job details #2051
Add Job Viewer visual element to display job details #2051
Conversation
@quest-bot loot #412 |
I had a few questions regarding this PR.
Additionally if there are any changes do let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-use :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you not reuse the JobViewer component ?
in the same folder, the file name should end with spec.tsx (check
frontend component name is calculated from backend name if not provided
a
No, you need to define a specific error variable name for this new component PS: please fix the linter errors and update your branch |
Are you still working on this PR @Nupoor10 ? |
If you're not, please close this PR |
This PR is regarding issue #412
It includes addition of a new job viewer visual element that is similar to the details panel of the Job Selector visual element