Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use transition property to show/hide the drawer #90633

Merged
merged 9 commits into from May 23, 2024

Conversation

gcsecsey
Copy link
Contributor

@gcsecsey gcsecsey commented May 13, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/7130

Proposed Changes

  • Use only the translate transition to show/hide the wrapper

Testing Instructions

CleanShot.2024-05-13.at.14.59.08.mp4
CleanShot.2024-05-13.at.15.00.06.mp4
CleanShot.2024-05-13.at.15.00.58.mp4

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gcsecsey gcsecsey requested a review from epeicher May 13, 2024 13:57
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug test/transition-browser-support on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented May 13, 2024

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Base automatically changed from update/show-get-report-form to trunk May 13, 2024 14:14
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that @gcsecsey, the changes work perfectly in the three main browsers, Chrome, Firefox and Safari. They also simplify the code 🙌

Firefox Safari Chrome
CleanShot 2024-05-13 at 16 23 59 CleanShot 2024-05-13 at 16 24 37 CleanShot 2024-05-13 at 16 25 53

@gcsecsey gcsecsey merged commit d0fa320 into trunk May 23, 2024
10 checks passed
@gcsecsey gcsecsey deleted the test/transition-browser-support branch May 23, 2024 12:29
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants