Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Headers for site management panel #90630

Merged
merged 4 commits into from May 14, 2024

Conversation

candy02058912
Copy link
Contributor

@candy02058912 candy02058912 commented May 13, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7083

Proposed Changes

  • Adjust Headers so that all tabs in the site management panel look consistent

Overview

  • Added header and subheader

overview

Hosting Config

  • Updated header from "Hosting" to "Hosting Config"

hosting config

Monitoring

  • Updated header

monitoring

PHP Logs

  • Added header and subheader

php logs

Server Logs

  • Added header and subheader

server logs

GitHub Deployments

  • Updated copy for subheader

github deployments

Testing Instructions

  • Go to sites dashboard and check the site management screen for atomic sites
  • Make sure everything looks good

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@candy02058912 candy02058912 requested review from a team May 13, 2024 13:00
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2024
@candy02058912 candy02058912 self-assigned this May 13, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/site-management-panel-header on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented May 13, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~3915 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
site-monitoring     +14155 B  (+1.4%)    +3851 B  (+1.2%)
hosting               +176 B  (+0.0%)      +64 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monitoring

Should we also include the word Monitoring in the header for consistency? I'm proposing the following:

image

cc-ing @lucasmendes-design for review

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the gap between the header and the bounding box is a bit larger than Figma design. The margin-left should be larger than the margin-top, but in this PR it is the opposite:

Figma This PR
image image

Can't really confirm as I am still requesting Figma Dev Mode (somehow I lost the access)

@lucasmendes-design
Copy link

About the spacing
9873489134
973498234

@lucasmendes-design
Copy link

Specs can be found in this Figma file
https://www.figma.com/design/kyCC1EHKtv4qsElmlAzp5T/Flyout-panel-i2?node-id=182%3A86182&t=wtSkkUkf8Qiz6w5u-1

@lucasmendes-design
Copy link

Should we also include the word Monitoring in the header for consistency? I'm proposing the following:

Yes. I also prefer this way :)

@candy02058912
Copy link
Contributor Author

I think the gap between the header and the bounding box is a bit larger than Figma design. The margin-left should be larger than the margin-top, but in this PR it is the opposite:

Fixed

padding

gap

@candy02058912 candy02058912 requested a review from fushar May 14, 2024 07:08
@candy02058912 candy02058912 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 14, 2024
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!!

@candy02058912 candy02058912 merged commit df0ba7a into trunk May 14, 2024
13 checks passed
@candy02058912 candy02058912 deleted the update/site-management-panel-header branch May 14, 2024 08:00
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels May 14, 2024
@lucasmendes-design
Copy link

Thanks, folks. It's perfect :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants