Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pinghub connection #90579

Closed
wants to merge 3 commits into from
Closed

Test pinghub connection #90579

wants to merge 3 commits into from

Conversation

gcsecsey
Copy link
Contributor

@gcsecsey gcsecsey commented May 10, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/6673

Proposed Changes

  • DO NOT MERGE
  • This diff adds changes to test websocket connections to not user-specific paths

Testing Instructions

Both with logged-in and logged-out sessions:

  • Go to /site-profiler
  • On site load, the websocket connection should be successful
  • Try clicking the disconnect and re-connect buttons to test the connection
  • When the connection is open, open the devtools Networking tab, click the test connection, and open the Messages tab
  • Open a new tab to https://public-api.wordpress.com/pinghub/wpcom/pub/test?action=connect, and send some test messages
  • Check that you can see the posted messages on the site-profiler tab devtools
CleanShot.2024-05-10.at.15.40.24.mp4

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gcsecsey gcsecsey changed the title Test/pinghub connection Test pinghub connection May 10, 2024
@matticbot
Copy link
Contributor

matticbot commented May 10, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~206 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
site-profiler       +720 B  (+0.8%)     +206 B  (+0.8%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gcsecsey
Copy link
Contributor Author

We've decided on the linked issue to proceed with polling instead of using websockets

@gcsecsey gcsecsey closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants