Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembler: Remove inherited color styling from linked headings #8206

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Assembler: Remove inherited color styling from linked headings #8206

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1046827
Remove inherited color styling from linked headings
ivan-ottinger Sep 26, 2024
705a6e5
Add the color inherit back, but without `!important`
ivan-ottinger Sep 26, 2024
b6f234b
Remove inheritance
richtabor Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions assembler/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ Text Domain: assembler
Tags: blog, one-column, three-columns, wide-blocks, block-patterns, custom-colors, custom-logo, custom-menu, editor-style, featured-images, full-site-editing, rtl-language-support, style-variations, template-editing, theme-options, threaded-comments, translation-ready
*/

/* Make link colors match text colors. */

h1 a, h2 a, h3 a, h4 a, h5 a, h6 a {
color: inherit !important;
Copy link
Contributor

@zaguiini zaguiini Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we remove the !important but keep the inheritance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Luis. Good point. I did not observe any issues when we remove the !important. It might be a safer approach to keep the color inheritance in place. → Added it back in the latest commit.

}

/* Remove auto-applied padding on headings when color is applied. */

h1.has-background, h2.has-background, h3.has-background, h4.has-background, h5.has-background, h6.has-background {
Expand Down
Loading