Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bysshe: Add theme #8154

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Bysshe: Add theme #8154

merged 3 commits into from
Sep 18, 2024

Conversation

iamtakashi
Copy link
Contributor

Add the Bysshe theme created by @mtias and @pablohoneyhoney. pNEWy-hIc-p2

This theme carries an image from Unsplash, this will not be submitted to WP.org and be available on WP.com only.

screenshot

Copy link
Contributor

github-actions bot commented Sep 14, 2024

Preview changes

I've detected changes to the following themes in this PR: Bysshe.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@iamtakashi iamtakashi added the Ready to launch Add this label if this is the first PR for a new theme label Sep 16, 2024
@vcanales vcanales mentioned this pull request Sep 17, 2024
@matiasbenedetto matiasbenedetto added Ready to launch Add this label if this is the first PR for a new theme and removed Ready to launch Add this label if this is the first PR for a new theme labels Sep 17, 2024
@iamtakashi
Copy link
Contributor Author

Found a reference to unsplash.com

Yes, the designer, Matías, is fine with this theme being only on WP.com. Let me know when it's ok to merge.

@iamtakashi iamtakashi self-assigned this Sep 18, 2024
@MaggieCabrera
Copy link
Contributor

This is looking good to me. I don't know about the paragraphs with the dots and translations, since they are decorative, maybe we could use esc_html_x for those to add context for translators so they know that they are just symbols? It's still not super accessible but I think it shouldn't be a blocker

esc_html_x( 'Title', 'context for translators', 'text-domain' );

@iamtakashi
Copy link
Contributor Author

@MaggieCabrera Thanks for the review. That is a good point to use esc_html_x for those decorative text elements, but I wonder if they need to be translated. What do you think?

Copy link
Contributor

Theme-Check results

bysshe: No changes required ✅.

❎ REQUIRED

  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
💡 RECOMMENDED (2)
  • No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
ℹ️ INFO (1)
  • Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs. The domain found is bysshe.

@iamtakashi
Copy link
Contributor Author

Anyway, I've changed it to use esc_html_x() for the symbols. I'll merge it when it passes the automated checks.

@iamtakashi iamtakashi merged commit 77fea11 into trunk Sep 18, 2024
3 checks passed
@iamtakashi iamtakashi deleted the add/bysshe branch September 18, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants