Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nausicaa #8146

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Add Nausicaa #8146

wants to merge 1 commit into from

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

Related issue(s):

@scruffian scruffian added the Ready to launch Add this label if this is the first PR for a new theme label Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Nausicaa.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@matiasbenedetto matiasbenedetto added Ready to launch Add this label if this is the first PR for a new theme and removed Ready to launch Add this label if this is the first PR for a new theme labels Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme-Check results

nausicaa: There are required changes on the theme ❌.

❎ REQUIRED

  • Both DOS and UNIX style line endings were found in the file readme.txt. This causes a problem with SVN repositories and must be corrected before the theme can be accepted. Please change the file to use only one style of line endings.
  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
💡 RECOMMENDED (3)
  • No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • Tested up to is recommended to have major versions only (e.g. 5.8). Patch version is not needed (e.g. 5.8.1).
⚠️ WARNING (1)
  • screenshot.png is 548.0 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
ℹ️ INFO (13)

@henriqueiamarino henriqueiamarino marked this pull request as draft September 24, 2024 11:39
@henriqueiamarino henriqueiamarino self-assigned this Oct 1, 2024
@iamtakashi iamtakashi changed the title Add nausicaa Add Nausicaa Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henriqueiamarino henriqueiamarino Awaiting requested review from henriqueiamarino

Assignees

@henriqueiamarino henriqueiamarino

Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scruffian @matiasbenedetto @henriqueiamarino