Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raconteur: add theme #8142

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Raconteur: add theme #8142

merged 3 commits into from
Sep 24, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

A theme to promote marvelous stories, Raconteur displays enlarged imagery and typography on a practical layout to attract readers to your narrative.

Demo site

screenshot

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Preview changes

I've detected changes to the following themes in this PR: Raconteur.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@henriqueiamarino henriqueiamarino added the Ready to launch Add this label if this is the first PR for a new theme label Sep 13, 2024
@scruffian
Copy link
Member

Oh sorry I just pushed over this, hope you didn't lose anything.

@henriqueiamarino
Copy link
Collaborator Author

Hey @scruffian, I am trying to figure out what happens once you force-push something over a PR. I am a newbie on GH. Anyway, as I see patterns from another theme here, I believe it's better if I commit to the theme again. Is that correct?

Screenshot 2024-09-13 at 17 49 44

@henriqueiamarino
Copy link
Collaborator Author

I won't be here for a week, so I'll attach the proper theme file to this conversation, @MaggieCabrera. This should be committed to the PR. I tried, but I can't after @scruffian force-pushed another version.

I'll keep an eye on it and reply until Monday morning if someone shows up.
raconteur.zip

@MaggieCabrera
Copy link
Contributor

I updated this branch with Henrique's changes

@henriqueiamarino henriqueiamarino self-assigned this Sep 20, 2024
@henriqueiamarino henriqueiamarino merged commit a552324 into trunk Sep 24, 2024
2 of 3 checks passed
@henriqueiamarino henriqueiamarino deleted the add/raconteur branch September 24, 2024 09:04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please remove all the psychedeli-related code? I think this was included in this PR by mistake.
cc @MaggieCabrera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants