Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kamala #8138

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Add Kamala #8138

merged 3 commits into from
Oct 1, 2024

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Sep 13, 2024

Changes proposed in this Pull Request:

Needs a new name

Related issue(s):

Uploading kamalastudio.WordPress.2024-09-16.xml.zip…

@scruffian scruffian added the Ready to launch Add this label if this is the first PR for a new theme label Sep 13, 2024
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Preview changes

I've detected changes to the following themes in this PR: Kamala.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@iamtakashi iamtakashi self-assigned this Oct 1, 2024
@iamtakashi
Copy link
Contributor

iamtakashi commented Oct 1, 2024

This theme uses images from Unsplash, but as a part of reducing the backlog, I'll work on this theme to launch only on dotcom.

@iamtakashi
Copy link
Contributor

@beafialho Could you let me know the source of the following two photos?
homepage_image_2-1024x671
homepage_image_3-1024x557

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Theme-Check results

kamala: There are required changes on the theme ❌.

❎ REQUIRED

  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).

@iamtakashi
Copy link
Contributor

The theme check fails because of the use of the Unsplash image, but this theme is going to launch only on Dotcom, so I'm merging it. We can add the info about the images above when we can. The info isn't important for a Dotcom-exclusive theme.

@iamtakashi iamtakashi merged commit 0439f7d into trunk Oct 1, 2024
2 of 3 checks passed
@iamtakashi iamtakashi deleted the add/kamala branch October 1, 2024 17:12
@beafialho
Copy link
Collaborator

@beafialho Could you let me know the source of the following two photos?

This theme was a spin-off, so it uses Unsplash images.

@iamtakashi
Copy link
Contributor

@beafialho Yes, I assumed they were from Unsplash, but it'd still be good to list the source in the readme.txt. I tried to search them in Unsplash but failed. Do you remember by any chance?

@beafialho
Copy link
Collaborator

@iamtakashi
Copy link
Contributor

No worries! Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants