-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assembler: Improving styles #8027
Conversation
Preview changesI've detected changes to the following themes in this PR: Assembler. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
e045d9b
to
111a93c
Compare
You can test this better using the playground builder, with these steps, as it includes content to demo with. Would be nice if themes can include their own playground blueprint.json, in the automated GitHub action here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Tested with:
- Editor
- Theme Showcase preview
- Public library
- Assembler flow
blockquote { | ||
text-wrap: balance; | ||
h1 a, h2 a, h3 a, h4 a, h5 a, h6 a { | ||
color: inherit !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @richtabor 👋🏼🙂 Looks like the !important
caused a small regression here: #8193.
I wonder what was the underlying need for this color override. As when removing it in my tests, it doesn't seem to cause any issues. 🤔 I suspect there might be some case I am missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a PR with the fix ready for review: #8206.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look, thanks :)
Changes proposed in this Pull Request:
Visual
CleanShot.2024-09-13.at.12.27.55.mp4