Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adonay: Add new theme #7954

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Adonay: Add new theme #7954

merged 3 commits into from
Aug 1, 2024

Conversation

jasmussen
Copy link
Member

Alternative to #7928. Includes the same changes. Let's see if the playground link works so we can test this.

@jasmussen jasmussen requested a review from beafialho July 16, 2024 12:09
@jasmussen jasmussen self-assigned this Jul 16, 2024
@jasmussen jasmussen mentioned this pull request Jul 16, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024 •
edited
Loading

Preview changes

I've detected changes to the following themes in this PR: Vows, Course, Dara, OutNow, Upsidedown, Iotix, Canard, Blissed, MyMenu, Stageplay, Adonay.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@beafialho
Copy link
Collaborator

Thank you for the review, this looks good to me!

@beafialho
Copy link
Collaborator

@mikachan do you think it's fine to Squash and merge this one?

@mikachan
Copy link
Member

It looks like there are a few .DS_Store files that should ideally be removed before merging, but all the other files look good to me 👍

@jasmussen
Copy link
Member Author

Given the green check, I'll go ahead and merge this. Kudos Bea!

@jasmussen jasmussen merged commit c72c53f into trunk Aug 1, 2024
2 checks passed
@jasmussen jasmussen deleted the beafialho-playground-changes-2024-07-04T15-33-13-200Z branch August 1, 2024 07:45
@MaggieCabrera MaggieCabrera changed the title Beafialho playground changes 2024 07 04 t15 33 13 200 z Adonay: Add new theme Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beafialho beafialho beafialho approved these changes

Assignees

@jasmussen jasmussen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasmussen @beafialho @mikachan