Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeanCV: Use shared color variations #7923

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Conversation

richtabor
Copy link
Contributor

@richtabor richtabor commented Jul 3, 2024

Exploring sharing variations between Assembler and other block themes.

I picked a few color variations from Assembler that closely resembled the original ones, and made a few slight adjustments to the duotones to allow for better interoperability across styles/themes.

Also made a few changes to markup while I was in there.

leancv-styles.mp4

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Preview changes

I've detected changes to the following themes in this PR: LeanCV.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@richtabor richtabor self-assigned this Jul 3, 2024
@richtabor richtabor added the [Type] Enhancement New feature or request label Jul 3, 2024
@richtabor richtabor marked this pull request as ready for review July 3, 2024 22:58
@richtabor richtabor changed the title Add LeanCV variations (WIP) Add LeanCV variations Jul 3, 2024
@richtabor richtabor changed the title Add LeanCV variations LeanCV: Use shared variations Jul 3, 2024
@richtabor richtabor changed the title LeanCV: Use shared variations LeanCV: Use shared color variations Jul 3, 2024
@henriqueiamarino henriqueiamarino merged commit f8c28d0 into trunk Jul 5, 2024
3 checks passed
@henriqueiamarino henriqueiamarino deleted the leancv/variations branch July 5, 2024 13:18
Copy link
Collaborator

@henriqueiamarino henriqueiamarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine with the variations, they are good to go @richtabor. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants