Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Use variation partials and move styles.blocks.variations to styles.variations #7891

Merged
merged 16 commits into from
Jul 8, 2024

Conversation

richtabor
Copy link
Contributor

Follow up to WordPress/gutenberg#62712, which adjusts where block style variations are defined with in theme style variations, as well as better leveraging style variation partials.

To test, load up WordPress/gutenberg#62712, then change to alternate color palettes. It should work exactly as previously.

@richtabor richtabor added the [Type] Enhancement New feature or request label Jun 21, 2024
@richtabor richtabor self-assigned this Jun 21, 2024
@richtabor
Copy link
Contributor Author

Relies on WordPress/gutenberg#62712 merged, into Gutenberg and perhaps for WordPress 6.6.

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Preview changes

I've detected changes to the following themes in this PR: Assembler.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Jul 1, 2024

Tested well for me on Gutenberg trunk (18.7RC) and WP 6.5.5

@richtabor
Copy link
Contributor Author

Went ahead and tweaked the form input styles to work better across all block style variations as well.

@richtabor richtabor force-pushed the assembler/variations-update branch from ba7ac8c to 8656466 Compare July 3, 2024 21:43
@richtabor
Copy link
Contributor Author

@alaczek @miksansegundo Do you mind giving this another good look over? Much appreciated! 🙇

@miksansegundo
Copy link
Contributor

I'm still reviewing this.

So far, I have found some issues with some variations:

  • A low contrast between the background and text colors on the footer.
  • Some colors in the variation card aren't applied in the preview.

@miksansegundo
Copy link
Contributor

miksansegundo commented Jul 5, 2024

A low contrast between the background and text colors on the footer.

This issue is not in the variations but in the preview of the Dotcom theme details page. I'm debugging it.

Some colors in the variation card aren't applied in the preview.

This issue affects the editor and assembler and is in the JSON files of Auburn, Meadow, Fluorescent, Citron, Sunset, Blush, and Tangerine. Can we update the default colors for these?

I would expect those variations to use some of their most representative colors in their default section style variation, but they don't, and when choosing them in the editor or Assembler flow, they look black and white.

Screenshot 2567-07-05 at 14 04 36

Here are the previews for Auburn, as an example:

Screenshot 2567-07-05 at 14 07 01 Screenshot 2567-07-05 at 14 06 43 Screenshot 2567-07-05 at 14 06 31

@richtabor
Copy link
Contributor Author

richtabor commented Jul 5, 2024

I would expect those variations to use some of their most representative colors in their default section style variation, but they don't, and when choosing them in the editor or Assembler flow, they look black and white.

This issue affects the editor and assembler and is in the JSON files of Auburn, Meadow, Fluorescent, Citron, Sunset, Blush, and Tangerine. Can we update the default colors for these?

I would expect those variations to use some of their most representative colors in their default section style variation, but they don't, and when choosing them in the editor or Assembler flow, they look black and white.

Here are the proper colors, as seen in the Assembler theme when viewing it locally. They are representative of their colors. Is the demo site using G 18.7+?

Meadow Citron
CleanShot 2024-07-05 at 11 30 33 CleanShot 2024-07-05 at 11 32 38

@richtabor
Copy link
Contributor Author

We should also update the demo site for Assembler to showcase more content (perhaps the second pattern could have a section style, but not the third—don't want to overdo it.

CleanShot 2024-07-05 at 11 39 26

Copy link
Contributor

@miksansegundo miksansegundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. It's working fine in the editor.

My confusion was that some of their colors, which look to me as the most representative, are used in the section style variations 1 to 3, not necessarily on the default variation. Therefore, those colors won't appear on the previews until we add their corresponding CSS classes to some patterns.

Let's follow up with any adjustments to make the dotCom previews look better in:

  1. Theme showcase previews show the wrong color on the footer
  2. Assembler highlights the default colors on the variation miniatures, and many of them look black and white
Screenshot 2567-07-08 at 13 16 17

@miksansegundo miksansegundo merged commit f5bc619 into trunk Jul 8, 2024
2 checks passed
@miksansegundo miksansegundo deleted the assembler/variations-update branch July 8, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants