Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message: add theme #7888

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Message: add theme #7888

merged 2 commits into from
Sep 11, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Jun 21, 2024

Message is a theme that brings the mobile messaging experience to your WordPress site.
Demo site

screenshot

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Preview changes

I've detected changes to the following themes in this PR: Message.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@alaczek
Copy link
Contributor

alaczek commented Aug 29, 2024

I found a few issues with this theme:

  • query loop in the front page template is set to custom, and won't follow posts per page settings
  • this section in the front page template feels excessive for a blog theme. I appreciate you wanted to educate the customers, but these aren't particularly instructive. We know interacting with the editor can be hard for customers - we shouldn't include sections that have to be manually removed:
image
  • the theme includes both home and front-page templates, that are virtually the same. Blog theme doesn't need both.
  • footer has the word "Seen" - what is the purpose of that?
image

@MaggieCabrera MaggieCabrera added Ready to launch Add this label if this is the first PR for a new theme and removed Ready to launch Add this label if this is the first PR for a new theme labels Sep 3, 2024
@henriqueiamarino henriqueiamarino merged commit ea39cdb into trunk Sep 11, 2024
2 checks passed
@henriqueiamarino henriqueiamarino deleted the add/message branch September 11, 2024 10:14
@henriqueiamarino
Copy link
Collaborator Author

@MaggieCabrera, here's the demo content file.

message.WordPress.2024-09-12.xml.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants