-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP-DOS: add theme #7879
WP-DOS: add theme #7879
Conversation
Preview changesI've detected changes to the following themes in this PR: Alves, Appleton, Artly, Assembler, Attar, Balasana, Barnsbury, Bitácora, Brompton, Calm Business, Canard, Cookbook, Course, Coutoire, Dalston, Dara, Dorna, Elegant Business, Erma, Eventual, Exford, Farrow, Foam, Fontaine, Friendly Business, George Lois, Hall, Heiwa, Hever, Iotix, Jaida, Leven, Loïc, Luminance, Marl, Mayland, Maywood, Meraki, Modern Business, Morden, Muscat, Otis, Pendant, Photos, Professional Business, Redhill, Rivington, Rockfield, Russell, Seedlet, Shawburn, Sophisticated Business, Stow, Stratford, Sunderland, Upsidedown, Varia, Vitrum, WP-DOS. You can preview these changes by following the links below:
I will update this comment with the latest preview links as you push more changes to this PR. |
Thanks, @jasmussen. As I can see from your screenshots, the background is now showing great. I'll iterate it following your general feedback. |
"backgroundImage": { | ||
"id": 1290, | ||
"source": "file", | ||
"src": "file:./assets/images/dos_noise-texture.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting, the background is defined here, so this looks fine.
@jasmussen I fixed everything you mentioned, but I couldn't figure out a better way to set an inverted (white to black) style variation. I created it, but as the background image is not affected by duotones, it doesn't change. Should we keep it like that and make it clear on the page showcase for users to replace the bg image? Or is it better to remove it? In time, I tried an image based on transparency, but the effect didn't work anyway. |
I see, yes, the light style is difficult with the dark background. One option would be if the PNG for the background had transparency, rather than a black fill. Or perhaps that transparency is already present, but the duotone just makes it black? In that case, perhaps it might work if there's a solid fill instead of a transparent background? If it's easy to test, see if it works. But otherwise, it's fine to launch this without the light style! Thanks for trying it. |
It sounds like it's non-trivial. Skip the light theme, it's fine! I am also realizing in this, that you can't apply duotone to the site-global background image, I believe the filter gets inherited for all contents inside, unless separate mechanisms are applied. We can't have that. |
Ok, it's done. Font and style variation removed; thank you. |
WP-DOS is a blog theme designed for nostalgic ones. It is a tribute to the folks who invented computing as we know it today. It is an exciting opportunity to test blogging as if we were back again to the green (or amber) phosphor.
Demo site