Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brute: add theme #7876

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Brute: add theme #7876

merged 6 commits into from
Sep 6, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Jun 19, 2024

Brute is a theme design inspired by the Brutalist concepts of the homonymous Architectural movement. It aims to be harsh, honest, utilitarian, and useful. It is a good portfolio pick for architects, design studios, and creative organizations.

Demo site

screenshot

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Preview changes

I've detected changes to the following themes in this PR: Brute.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@alaczek
Copy link
Contributor

alaczek commented Aug 29, 2024

I've found some issues with the theme:

  • custom page-blog.html template isn't necessary.
  • there are multiple H1 elements on the homepage used for decorative, rather than semantic purposes, which is an accessibility issue (see this article for more details)
  • there's a broken block in the search template:
image

@MaggieCabrera MaggieCabrera added the Ready to launch Add this label if this is the first PR for a new theme label Sep 3, 2024
@henriqueiamarino
Copy link
Collaborator Author

@alaczek, I have fixed the following issues on the latest commit:

  • Fixed the broken block in the search template;
  • Replace images that were using AI to prevent a block;
  • New fonts were added to the style variations.

@MaggieCabrera
Copy link
Contributor

I made a little fix with the esc_attr_e for this one. I'm a little confused with the images. I see 2 files in the assets, and 1 in the screenshot, but I see 5 in the licenses, can you remove the ones that are unused? Does the theme screenshot need to be updated too?

@henriqueiamarino
Copy link
Collaborator Author

@MaggieCabrera, I provided the credits for all the images I use on the homepage. While two of them are packed within the theme, just one is shown on the screenshot. Should I credit only that one? This confuses me sometimes... screenshot is fine, updated.

@MaggieCabrera
Copy link
Contributor

I think your commit removed my changes

@MaggieCabrera
Copy link
Contributor

And about the credits: you don't need to credit what's on the demo site, only what you can see when you install the theme fresh from these files, that means:

  • whatever images you can see on the screnshot
  • whatever files are loaded in the assets

And of course we shouldn't load images externally, they should be packaged in the assets files

@henriqueiamarino
Copy link
Collaborator Author

henriqueiamarino commented Sep 6, 2024

Oh no, sorry about that, @MaggieCabrera. Before doing so, I checked the Update Branch button as you instructed me 😔
Anyway, I checked the inevitable html/attr issue you fixed before, and they are present in the latest commit.

Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@henriqueiamarino henriqueiamarino merged commit bd88bef into trunk Sep 6, 2024
2 checks passed
@henriqueiamarino henriqueiamarino deleted the add/brute branch September 6, 2024 15:17
@henriqueiamarino
Copy link
Collaborator Author

@MaggieCabrera, here's the demo content file.

brute.WordPress.2024-09-12.xml.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants