Update theme foam #7860
Open
Update theme foam #7860
+5
−348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing side padding to header Also exported as a zip file. * [Preview loaded from this PR – available **before** this PR is merged](https://playground.wordpress.net/?import-site=https%3A%2F%2Fraw.githubusercontent.com%2Fautomattic%2Fthemes%2Fplayground-changes-2024-06-17T13-49-20-041Z%2Ffoam%2Fplayground.zip) * [Preview loaded from the main branch – available **after** this PR is merged](https://playground.wordpress.net/?import-site=https%3A%2F%2Fraw.githubusercontent.com%2Fautomattic%2Fthemes%2Ftrunk%2Ffoam%2Fplayground.zip)
|
@mikachan I'm catching up on old PRs and skilling up so I can help. For this one, PR looks good, it's got a green check. But there's a failing test for "Preview theme changes". I tried restarting that check, but it failed again. Any tips for what to do in this situation? No rush. |
The failed PR preview is related to this, as @beafialho said. It's because we can't create the theme preview based on forks of a repo, due to security reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from WordPress Playground:
Also exported as a zip file.