Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrals: Integrate api call for get redeem code #2205

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 25, 2024

| 📘 Part of: #2083 |
|:---:|

Fixes #

1 2 3 4
IMG_0146 IMG_0147 IMG_0149 IMG_0148

To test

  1. Start the app
  2. Ensure you the Referrals FF enabled and you are using a Plus or Patron account
  3. Go to Profile
  4. Tap on the gift icon on the top left
  5. Tap On Share Guest Pass
  6. See the Share system view
  7. Choose different types of Share and check if they work correctly and show your custom referral URL: https://pocketcasts.com/redeem/XXXXXX
  8. Share and see if you go back to the profile screen.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 25, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.74. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review September 25, 2024 21:23
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 25, 2024 21:23
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team September 25, 2024 21:23
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Sergio 2 small things for now:

• the card background is white
• the URL is posted twice

IMG_2556
IMG_2557

@SergioEstevao
Copy link
Contributor Author

@danielebogo

the card background is white

Fixed here: fd2ce54

The double url on sharing is intentional for now, I will create a separate PR to address it. I will need to set the shared items depending of the Shared to app.

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The card background color is correct now!

@SergioEstevao SergioEstevao merged commit bc0ff58 into trunk Sep 26, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the referrals/integrate_api_call_for_get_code branch September 26, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants