Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #2141: Skip Back issue when skipping from watch #2197

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Sep 24, 2024

Fixes #2141

In #2041 we added logic to ignore skips which would skip ahead. However, the Watch skipBack function is called on a background thread and the timer never appears to fire, causing previousSeekTime to never be reset to nil, breaking all future skip backs.

Considerations

I also considered adding the Debouncer to the Main RunLoop instead of scheduling on its current RunLoop. This would apply to other caller of skipBack but I checked all of these and I believe all will come from the main thread. I'm concerned this could cause race conditions if the callback relies on the original behavior.

To test

  • Play an episode on the phone
  • Use the watch app to skip back
  • Check that skip back worked
  • Try skipping back on the phone
  • Ensure that skipping worked

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus requested a review from a team as a code owner September 24, 2024 02:18
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team September 24, 2024 02:18
@bjtitus bjtitus changed the base branch from trunk to release/7.73 September 24, 2024 02:19
@bjtitus bjtitus added the [Type] Bug Used for issues where something is not functioning as intended. label Sep 24, 2024
@bjtitus bjtitus added this to the 7.73 ❄️ milestone Sep 24, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 24, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.73 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@bjtitus bjtitus force-pushed the bjtitus/playback/watch-skipback-queue branch from 60aa524 to aed6c4c Compare September 24, 2024 02:24
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on device and it's working great!

@bjtitus bjtitus merged commit 97423ad into release/7.73 Sep 24, 2024
4 of 6 checks passed
@bjtitus bjtitus deleted the bjtitus/playback/watch-skipback-queue branch September 24, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip Back is not working
3 participants