Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the now playing info when player is not seeking #2186

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Sep 21, 2024

This was discovered while testing #2141 but is a bit different from the original issue.

The player seekTo completion was updating the now playing info but the else block (updating the episode timestamp directly without the player's involvement) was not.

To test

  • Play an episode
  • Lock the phone (or navigate to control center) to see the Media Controls
  • Pause playback on the lock screen
  • Tap the Skip Back button
  • Notice that progress is reflected in the progress bar or timestamps

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added [Type] Bug Used for issues where something is not functioning as intended. playback Issues related to playback labels Sep 21, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 21, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@bjtitus bjtitus marked this pull request as ready for review September 21, 2024 03:14
@bjtitus bjtitus requested a review from a team as a code owner September 21, 2024 03:14
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team September 21, 2024 03:14
@danielebogo
Copy link
Contributor

@bjtitus can we have this targeting our release branch?

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjtitus

I tested it and the skip back/forward buttons work now when the Effects player is nil and I'm on the lock screen. I also checked the values and they are reflected in both lock screen and in app.

Just 2 things:
Can we update the changelog?
Can we also target release/7.73? So we can start testing it in beta.

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@bjtitus bjtitus changed the base branch from trunk to release/7.73 September 23, 2024 17:49
@bjtitus bjtitus merged commit 03fe320 into release/7.73 Sep 23, 2024
4 of 6 checks passed
@bjtitus bjtitus deleted the bjtitus/playback/mpnowplayinginfo branch September 23, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playback Issues related to playback [Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants