Referrals: send pass share #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
changed the base branch from
trunk
to
referrals/update_to_unlimited_passes
# Conflicts: # podcasts/en.lproj/Localizable.strings
Base automatically changed from
referrals/update_to_unlimited_passes
to
trunk
September 17, 2024 10:28
SergioEstevao
requested review from
danielebogo
and removed request for
a team
danielebogo
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Hey @SergioEstevao works as described.
I just left few comments about the URL which can be replaced by a constant we already have
podcasts/ProfileViewController.swift
Outdated
| @@ -500,7 +500,7 @@ class ProfileViewController: PCViewController, UITableViewDataSource, UITableVie | |||
|
|
|||
| @objc private func referralsTapped() { | |||
| hideReferralsHint() | |||
| let viewModel = ReferralSendPassModel(offerInfo: referralsOfferInfo, | |||
| let viewModel = ReferralSendPassModel(offerInfo: referralsOfferInfo, referralURL: URL(string: "https://pocketcasts.com"), | |||
There was a problem hiding this comment.
Nit: we have a Server constant called pocketcastsDotCom -> ServerConstants.Urls.pocketcastsDotCom. We use it in few spot like the sharing helper.
There was a problem hiding this comment.
Good catch, but the URL here will be something defined by the server for each user... so this was a temporary use. But I updated it here to use the constant for now.
|
@danielebogo can you give it another look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| 📘 Part of: #2083 |
|:---:|
Fixes #
This PR adds the share capability for the Referrals send pass screen.
I initially tried to wrap the UIActivityViewController on an SwiftUI View but was having issues with the presentation using a bottom sheet ( there was always a part of the bottom sheet that didn't get the right color)
I tried to user ShareLink but the functionality is iOS 16 and above only so I needed to replicate it using UIActivityViewController any way.
In the end I'm using the UIActivityViewController in the host VC for the SendPass View. This allow me to proper display it and keep it contained inside the SendPass flow.
To test
Checklist
CHANGELOG.mdif necessary.