Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrals: Switch to 2 months and make display of offer duration more flexible #2162

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 11, 2024

| 📘 Part of: #2083 |
|:---:|

Fixes #

This PR updates the referrals code to support a more flexible way to define offer duration.
At the moment it changes the code to an hard coded 2 month duration but this will be resolved using IAP info in the future.

1 2 3
Simulator Screenshot - iPhone 15 Pro - 2024-09-12 at 14 26 27 Simulator Screenshot - iPhone 15 Pro - 2024-09-12 at 14 19 06 Simulator Screenshot - iPhone 15 Pro - 2024-09-12 at 14 18 57

To test

  1. Start the app from scratch
  2. Ensure that you have the referrals FF enabled
  3. Switch to the Profile view
  4. Ensure that you have a Plus subscription (You can do it in settings -> developer)
  5. Tap on the gift icon on the top
  6. See if the guest pass duration is show correctly. ( It should be 2 months)
  7. Tap on Close
  8. Check that banner info for claiming a guest pass shows correctly
  9. Tap on the banner for claiming guest pass
  10. Check that the guest pass offer duration (2 months) and price after offer (39.99) is show correctly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 11, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.73. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review September 11, 2024 15:13
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 11, 2024 15:13
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team September 11, 2024 15:13
@SergioEstevao SergioEstevao changed the title Referrals: Switch to 2 months and make offer duration more flexible Referrals: Switch to 2 months and make display of offer duration more flexible Sep 11, 2024
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified the guest pass time coming from the Gift button
✅ Verified the guest pass time + cost coming from the banner

Base automatically changed from referrals/claim_pass to trunk September 12, 2024 12:26
@SergioEstevao SergioEstevao merged commit 5eaa964 into trunk Sep 12, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the referrals/switch_to_2_months branch September 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants