Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrals: Claim pass #2158

Merged
merged 14 commits into from
Sep 12, 2024
Merged

Referrals: Claim pass #2158

merged 14 commits into from
Sep 12, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 10, 2024

| 📘 Part of: #2083 |

This PR implements only the UI for the claim passes flow. The signup and IAP flows will be done on a separate PR
At the moment because we don't have any server control logic the banner to claim passes will always be present .

1 2
Simulator Screenshot - iPhone 15 Pro - 2024-09-11 at 00 03 52 Simulator Screenshot - iPhone 15 Pro - 2024-09-11 at 00 04 01
Simulator Screenshot - iPad mini (6th generation) - 2024-09-11 at 00 09 21 Simulator Screenshot - iPad mini (6th generation) - 2024-09-11 at 00 09 25

To test

  1. Start the app
  2. Ensure that you have the referrals FF enabled
  3. Open profile
  4. Check that you see the banner for claim passes
  5. Tap on it
  6. See that you see the Claim pass view in a sheet
  7. Tap on not now
  8. Check that you are returned to Profile

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 10, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.73. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review September 10, 2024 23:14
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 10, 2024 23:14
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team September 10, 2024 23:14
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 One minor nit but this looked good in testing.

@SergioEstevao SergioEstevao merged commit 103352a into trunk Sep 12, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the referrals/claim_pass branch September 12, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants