Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrals: Add animated background gradient view to card. #2143

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 5, 2024

| 📘 Part of: #2083 |
|:---:|

Fixes #

This PR implements the animated gradient view for the referrals card

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-05.at.18.29.36.mp4

To test

  1. Start the app
  2. Ensure that you have the referrals FF enabled
  3. Ensure that you have a Plus or Patron account
  4. Open profile
  5. Tap on the gift icon on the top left
  6. Check that you see the animation like in the video above.
  7. Please test on a real device to see performance

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.73 milestone Sep 5, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review September 5, 2024 18:25
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 5, 2024 18:25
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team September 5, 2024 18:25
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as described! Looks good!

Just a nit: should we use Constants to define the values?

@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented Sep 6, 2024

Just a nit: should we use Constants to define the values?

Are you suggesting using parameters for the color values, speed of animations and things like that?

I thought about it, but this animation is so specific to the Referrals card that I think it's not worth it to make it configurable.

Base automatically changed from referrals/send_pass_ui to trunk September 6, 2024 13:04
@SergioEstevao SergioEstevao merged commit 004959b into trunk Sep 6, 2024
6 of 8 checks passed
@SergioEstevao SergioEstevao deleted the referrals/card_gradient_animation branch September 6, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants