Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrals: Entry point #2082

Merged
merged 14 commits into from
Aug 23, 2024
Merged

Referrals: Entry point #2082

merged 14 commits into from
Aug 23, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Aug 22, 2024

| 📘 Part of: #2083 |
|:---:|

Fixes #
This PR adds the following:

  • Adds a feature flag to control the display of referrals feature
  • Implements the entry point on the Profile View Controller and show the pass badge

Note: The color of the badge is being worked on by design to correctly work on all themes

1 2 3 4 5
Simulator Screenshot - iPhone 15 Pro - 2024-08-23 at 14 53 42 Simulator Screenshot - iPhone 15 Pro - 2024-08-23 at 14 53 27 Simulator Screenshot - iPhone 15 Pro - 2024-08-23 at 14 53 18 Simulator Screenshot - iPhone 15 Pro - 2024-08-23 at 14 53 09 Simulator Screenshot - iPhone 15 Pro - 2024-08-23 at 14 52 59

To test

  • Start the app
  • Ensure that have the Referrals FF active
  • Go to Profile Tab
  • If you are not logged in or don't have a subscription (Plus or Patron) you shouldn't see the gift icon on the top right
  • Only if you are logged in and have a active Subscription you should see the gift icon
  • Tap on the gift icon
  • Check that the badge number overlayed on the gift icon goes down
  • Check that when the number goes down to zero the badge icon is hidden

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao changed the title Referrals/entry point Referrals: Entry point Aug 22, 2024
@SergioEstevao SergioEstevao added this to the 7.72 milestone Aug 22, 2024
@SergioEstevao SergioEstevao marked this pull request as ready for review August 22, 2024 17:17
@SergioEstevao SergioEstevao requested a review from a team as a code owner August 22, 2024 17:17
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team August 22, 2024 17:17
podcasts/ProfileViewController.swift Outdated Show resolved Hide resolved
@SergioEstevao SergioEstevao merged commit 2ba8d2c into trunk Aug 23, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the referrals/entry_point branch August 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants