fix: verify delayed prompt can still be displayed before showing

[chickenn00dle]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1208253149260198/f

With ras-acc, it is now possible for segment conditions to change for the reader between when a delayed prompt is "queued" and when it is displayed. This PR adds a check for delayed prompts to ensure it should still be displayed before unhiding:

How to test the changes in this Pull Request:

To test, be sure to check out epic/ras-acc in blocks, theme, newsletters, and plugin

1. As admin, set up a registration block campaign for unregistered readers to render on every page or post view after a few seconds delay
2. As a logged out reader, visit the any page or post and confirm the registration overlay appears as expected (I had to clear local storage before this worked for me)
3. Refresh the page, and BEFORE the overlay appears quickly click the sign in button in the site header
4. Complete either the registration flow, or the sign in flow until the modal closes
5. On trunk the registration overlay will appear, but since you are signed in, you will see the success state of the registration block. On this branch, the overlay should no longer appear as the reader no longer matches the segment.
6. As admin again, disable the registration overlay and enable a new overlay (with any type of content) that targets everyone and appears on every page view after a few seconds delay.
7. Repeat steps 1-5, but this time verify the prompt DOES appear once the auth modal closes.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[chickenn00dle]

This is technically a fix for ras-acc, however this is still a general enhancement that applies outside of ras-acc, so targeting trunk for this. But let me know if you'd like me to open a new epic branch for this instead!

[laurelfulford]

Works as described! 🙌

I tested this against epic/ras-acc and it worked as described for both the registration prompt success message not showing, and a regular prompt showing after the RAS-ACC checkout was closed.

I also tested it against trunk, and the prompts kept working as expected (both for the registration, and a regular prompt).

[matticbot]

🎉 This PR is included in version 3.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀