Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Docker: add php ast ext #41288

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Dev Docker: add php ast ext #41288

merged 4 commits into from
Jan 24, 2025

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jan 23, 2025

This is needed for jp phan commands.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Run BUILD_LOCAL=1 jp phan before and after (may need to delete local image of the dev image if present on your system)

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. labels Jan 23, 2025
@kraftbj kraftbj self-assigned this Jan 23, 2025
@kraftbj kraftbj requested a review from a team January 23, 2025 18:52
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@kraftbj kraftbj added [Status] In Progress and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. labels Jan 23, 2025
@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. and removed [Status] In Progress labels Jan 24, 2025
@kraftbj kraftbj requested review from anomiex and a team January 24, 2025 17:43
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Let's do it.

I don't know how the main Dockerfile avoids the issues with python stuff without jumping through these hoops though.

tools/docker/Dockerfile.monorepo Show resolved Hide resolved
@kraftbj kraftbj merged commit 44fea3f into trunk Jan 24, 2025
61 checks passed
@kraftbj kraftbj deleted the add/php-ast-docker branch January 24, 2025 18:29
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker [Pri] Normal Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants