-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage: Fix warnings in scheduled updates package #40975
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and the test output has no warnings about @covers
anymore.
When running code coverage tests on
scheduled-updates
, we get 34 warnings due to errant@covers
annotations. This PR corrects those.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Check the CI Tests → Code Coverage run. On
trunk
it looks like this:https://github.com/Automattic/jetpack/actions/runs/12717372492/job/35453699359#step:10:8096
With this branch the warnings should be gone.