-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart Library: Add Grid #40683
base: trunk
Are you sure you want to change the base?
Chart Library: Add Grid #40683
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Temporary any types were added to the grid control scale props with TODO comments, addressing type conflicts between ScaleBand (bar charts) and ScaleLinear (line charts) in visx. Our previous approaches, including specific scale types, union types, and generic D3Scale types, either restricted reusability, caused further conflicts, or introduced unnecessary dependencies. This interim solution (any types) ensures flexibility across chart types while deferring a more type-safe implementation to future iterations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed changes:
This PR introduces a new grid control component
Changes Made:
Dependencies:
Component:
grid control
componentStorybook:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Run
pnpm install
as dependencies have been addedIn your Jetpack local env, navigate to the Storybook development environment:
Find
JS Packages/Charts/Grid Control
in the sidebarVerify the grids:
x
,y
,xy
, andnone
Find
JS Packages/Charts/Bar Chart
in the sidebar