Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Featured Image: enable Stable Diffusion to all users and improve tracking information #37474

Merged

Conversation

lhkowalski
Copy link
Contributor

@lhkowalski lhkowalski commented May 21, 2024

Depends on D149604-code. The required code got merged already.

Proposed changes:

  • Enable stable diffusion to 100% of the site base
  • Add site type to the events being tracked
  • Add generation model to the events being tracked
  • Drop the need of the jetpack_experimental_image_generation_enabled filter to enable the Stable Diffusion generation
  • Change the endpoint used to generate the images, to use the same that provides Dall-e-3 generation
  • Refactor code now that both endpoints are the same

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Yes, it's including the site type and the image generation model on the events tracked by the Featured Image Generation tool.

Testing instructions:

  • Sandbox the public-api and apply the D149604-code diff to your sandbox
  • Test it on a Simple site, a Jetpack site and, if possible, an Atomic site too
  • Run this branch on your testing site
  • Make sure beta blocks are disabled and you are running production blocks on your testing site
    • For Simple sites, use it unproxied so you get the production blocks
  • Go to the block editor, open the browser console and enable debug messages with localStorage.setItem( 'debug', '*' );
  • Add some content to the editor, than look for the AI Featured Image tool and click to generate the image
  • Confirm an image is generated
  • Confirm the generation event was triggered containing the site type and the image generation model
    • the site type needs to be the type of the site you are using for tests
    • the generation model needs to be stable-diffusion since you are using the beta variation
  • Confirm you can use the tool as expected, with follow ups and every other buttons working as expected

@lhkowalski lhkowalski added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label May 21, 2024
@lhkowalski lhkowalski requested a review from a team May 21, 2024 17:45
@lhkowalski lhkowalski self-assigned this May 21, 2024
Copy link
Contributor

github-actions bot commented May 21, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/ai-featured-image-stable-diffusion-soft-launch branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/ai-featured-image-stable-diffusion-soft-launch
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on June 3, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@lhkowalski lhkowalski marked this pull request as ready for review May 21, 2024 18:09
@lhkowalski lhkowalski changed the title AI Featured Image: launch Stable Diffusion to part of the user base and improve tracking information AI Featured Image: launch Stable Diffusion to 10% of the user base and improve tracking information May 21, 2024
@lhkowalski lhkowalski changed the title AI Featured Image: launch Stable Diffusion to 10% of the user base and improve tracking information AI Featured Image: enable Stable Diffusion to all users and improve tracking information May 21, 2024
dhasilva
dhasilva previously approved these changes May 21, 2024
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well on all platforms.

@lhkowalski lhkowalski requested review from dhasilva and a team May 22, 2024 20:29
Copy link
Contributor

@vianasw vianasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I tested it and it worked in all three site types.

/**
* The type of the response from the image generation API.
*/
type ImageGenerationResponse = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

@lhkowalski lhkowalski merged commit cee0c64 into trunk May 23, 2024
57 checks passed
@lhkowalski lhkowalski deleted the update/ai-featured-image-stable-diffusion-soft-launch branch May 23, 2024 15:15
@github-actions github-actions bot added this to the jetpack/13.5 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] AI Assistant [Extension] AI Assistant Plugin [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants