Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding unique assignment to .eng role #66

Draft
wants to merge 11 commits into
base: trunk
Choose a base branch
from

Conversation

katag9k
Copy link
Contributor

@katag9k katag9k commented Jul 3, 2024

What

Adds breakingAllowMultiRoles to config, which if set to false will ensure that .point, .comms, triage and .eng can only be assigned to unique users.

Why

It gives the option to ensure people do not assign themselves to multiple roles and take on too much work during a breaking incident.

How

  1. Set breakingAllowMultiRoles to false
  2. Start a new breaking
  3. Assign yourself to a role e.g. .comms
  4. Assign yourself to a different role e.g. .point
  5. The bot will not assign you to comms instead, it will let you know in a thread that you've already been assigned to a role
Screenshot 2024-07-10 at 12 05 33 PM Screenshot 2024-07-10 at 12 05 42 PM

@katag9k katag9k requested a review from mhsdef July 10, 2024 16:07
Copy link
Contributor

@mhsdef mhsdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I'll try to give this a spin ASAP.

Did you get any feedback from others re: blocking on multi assignment vs swapping assignment?

Right now, without the unassign, there's no way to switch role. And even with unassign--if we do that--it'll be a two step process which could be one step.

lib/boundary/hubot/handlers/incident.ts Outdated Show resolved Hide resolved
lib/boundary/hubot/handlers/incident.ts Outdated Show resolved Hide resolved
lib/boundary/hubot/handlers/incident.ts Outdated Show resolved Hide resolved
@katag9k
Copy link
Contributor Author

katag9k commented Jul 12, 2024

Looking good! I'll try to give this a spin ASAP.

Did you get any feedback from others re: blocking on multi assignment vs swapping assignment?

Right now, without the unassign, there's no way to switch role. And even with unassign--if we do that--it'll be a two step process which could be one step.

Not yet, as it is still in discussion. But if we don't have the unassign feature, then swapping roles will have to be an option here.

@katag9k katag9k marked this pull request as draft July 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants