Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Downgrade htmlAttrNotByEscHTML to a warning" #696

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Revert "Downgrade htmlAttrNotByEscHTML to a warning" #696

merged 1 commit into from
Sep 28, 2021

Conversation

rebeccahum
Copy link
Contributor

Reverts #693

After much discussion in #601, we should leave it to an error level.

@rebeccahum rebeccahum requested a review from a team as a code owner September 27, 2021 20:18
@rebeccahum rebeccahum added this to the 2.3.3 milestone Sep 27, 2021
@rebeccahum rebeccahum mentioned this pull request Sep 27, 2021
Merged
@rebeccahum rebeccahum merged commit 82c3b37 into develop Sep 28, 2021
@rebeccahum rebeccahum deleted the revert-693-downgrade_htmlAttrNotByEscHTML branch September 28, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryJones GaryJones GaryJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rebeccahum @GaryJones