Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade htmlAttrNotByEscHTML to a warning #693

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Downgrade htmlAttrNotByEscHTML to a warning #693

merged 1 commit into from
Jun 30, 2021

Conversation

rebeccahum
Copy link
Contributor

Fixes #601.

@rebeccahum rebeccahum requested a review from a team as a code owner June 30, 2021 16:34
jrfnl
jrfnl approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, but LGTM.

@rebeccahum rebeccahum merged commit 3aab322 into develop Jun 30, 2021
@rebeccahum rebeccahum added this to the 2.3.3 milestone Jun 30, 2021
@rebeccahum rebeccahum deleted the downgrade_htmlAttrNotByEscHTML branch June 30, 2021 17:45
@rebeccahum rebeccahum mentioned this pull request Jul 5, 2021
Open
This was referenced Sep 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.3
Development

Successfully merging this pull request may close these issues.

Convert htmlAttrNotByEscHTML to warning or back to error for consistency with other rules
2 participants
@rebeccahum @jrfnl