Skip to content

Commit

Permalink
GH Actions: PHP 8.4 has been released
Browse files Browse the repository at this point in the history
* Builds against PHP 8.4 are no longer allowed to fail.
* Add _allowed to fail_ build against PHP 8.5.

Ref: https://www.php.net/releases/8.4/en.php
  • Loading branch information
jrfnl committed Nov 21, 2024
1 parent ff4acee commit 9771ef4
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:

strategy:
matrix:
php: ['5.4', 'latest', '8.4']
php: ['5.4', 'latest', '8.5']

name: "Lint: PHP ${{ matrix.php }}"
continue-on-error: ${{ matrix.php == '8.4' }}
continue-on-error: ${{ matrix.php == '8.5' }}

steps:
- name: Checkout code
Expand Down Expand Up @@ -67,9 +67,9 @@ jobs:
# - PHPCS will run without errors on PHP 5.4 - 7.4 on any supported version.
# - PHP 8.0 needs PHPCS 3.5.7+ to run without errors, and we require a higher minimum version.
# - PHP 8.1 needs PHPCS 3.6.1+ to run without errors, but works best with 3.7.1+, and we require at least this minimum version.
# - PHP 8.2 and 8.3 need PHPCS 3.8.0+ to run without errors (though the errors don't affect the tests).
# - PHP 8.2, 8.3 and 8.4 need PHPCS 3.8.0+ to run without errors (though the errors don't affect the tests).
matrix:
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
dependencies: ['lowest', 'stable']

include:
Expand All @@ -80,16 +80,16 @@ jobs:
dependencies: 'dev'
- php: '7.4'
dependencies: 'dev'
- php: '8.3'
- php: '8.4'
dependencies: 'dev'

# Test against upcoming PHP version.
- php: '8.4'
- php: '8.5'
dependencies: 'dev'

name: "Test: PHP ${{ matrix.php }} - PHPCS ${{ matrix.dependencies }}"

continue-on-error: ${{ matrix.php == '8.4' }}
continue-on-error: ${{ matrix.php == '8.5' }}

steps:
- name: Checkout code
Expand Down

0 comments on commit 9771ef4

Please sign in to comment.