Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Durgod Nebula K320 RGB support #16

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MERR0N
Copy link

@MERR0N MERR0N commented Jan 26, 2022

Hello! I just added support for Durgod K320 Nebula RGB without required running Chroma SDK or Durgod Zeus Engine.

@Aytackydln
Copy link
Member

Hi, looked at your device code but didn't see any code indicating "direct mode".

We need to make sure these updates are not saved to device's memory. What happens if you shutdown fully then boot your PC? Do the colors stay?

@Aytackydln Aytackydln self-requested a review January 30, 2022 11:02
@Aytackydln
Copy link
Member

We shouldn't merge sdk that doesn't use direct mode. If the updates are made on static mode too fast updates wear the device's flash memory, eventually breaking it. Depending on the device no flash memory might brick it, just breaks some functionality (like macros) or do nothing at all. We can't take that risk

@gitmacer
Copy link
Member

I would prefer that you implement support through OpenRGB instead of direct Aurora support. That way even linux user can benefit from your work. Additionally Artemis and other apps users can control that device.

@Aytackydln
Copy link
Member

true, if you also show your codes in the issue on OpenRGB repository that would help their team too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants